This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
fix: use import resolver in LU parsing #6536
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boydc2014
suggested changes
Mar 29, 2021
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The read scenario works for me, the write scenario of inline lu editor doesn't behave as expect, it is not writing at the right location.
The inline lu editor always write to the dialog lu, instead of the imported lu when should.
…soft/BotFramework-Composer into zhixzhan/lu-parse-resolver
Contributor
Author
Fixed. now will write to correct file. |
boydc2014
approved these changes
Mar 31, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* use import resolver in lu parsing * update ut * handle lu resolve error * use origin fileId to update * update Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support lu parsing file with imports, get all intents from imports.
a.lu
b.lu
c.lu
parsing result for
a.luisTask Item
close #6489
refs #6512
Screenshots
inline editor show referenced intent

