Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Mar 24, 2021

Description

Support lu parsing file with imports, get all intents from imports.

a.lu

[import](b.lu)
# a
- 1

b.lu

[import](c.lu)
# b
- 2

c.lu

# c
- 1

parsing result for a.lu is

{
intent : [{ name: 'a', body :'1' }]
allIntent: [ { name: 'a', body :'1' }, { name: 'b', body :'2' }, { name: 'c', body :'3' } ]
...
}

Task Item

close #6489
refs #6512

Screenshots

inline editor show referenced intent
image
image

@zhixzhan zhixzhan marked this pull request as ready for review March 25, 2021 02:27
@coveralls
Copy link

coveralls commented Mar 25, 2021

Coverage Status

Coverage increased (+0.004%) to 52.045% when pulling 5036ad7 on zhixzhan/lu-parse-resolver into feac99a on main.

Copy link
Contributor

@boydc2014 boydc2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The read scenario works for me, the write scenario of inline lu editor doesn't behave as expect, it is not writing at the right location.
The inline lu editor always write to the dialog lu, instead of the imported lu when should.

@zhixzhan
Copy link
Contributor Author

The read scenario works for me, the write scenario of inline lu editor doesn't behave as expect, it is not writing at the right location.
The inline lu editor always write to the dialog lu, instead of the imported lu when should.

Fixed. now will write to correct file.

@boydc2014 boydc2014 merged commit 07f037c into main Mar 31, 2021
@boydc2014 boydc2014 deleted the zhixzhan/lu-parse-resolver branch March 31, 2021 07:23
@cwhitten cwhitten mentioned this pull request May 20, 2021
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* use import resolver in lu parsing

* update ut

* handle lu resolve error

* use origin fileId to update

* update

Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

inline lu editor did not show as expected for reference intent

4 participants