This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Remove nuget.config and cleanup #6506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricDahlvang
requested review from
benbrown,
boydc2014,
carlosscastro and
luhan2017
as code owners
EricDahlvang
changed the title
Contributor
|
@EricDahlvang the reason composer is on myget, is composer often consume the daily packages from SDK, which is in myget. And the current company policy don't allow us to use both myget + nuget at the same time, so eventually the call made is to use myget only with a feature "upstream source" configured to nuget. So unless we won't use daily packages anymore or we find a way out of policy, i think we probably should still keep using myget. cc @mrivera-ms @cwhitten knew the previous context here. |
Contributor
|
All looking good, just not sure about the nuget.config change. |
Member
Author
|
@boydc2014 I've added nuget.config back to this PR |
boydc2014
previously approved these changes
Mar 26, 2021
boydc2014
approved these changes
Mar 26, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Remove nuget.config and cleanup * Remove copywrite headers * Add back in nuget.config * Fix bad merge Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove nuget.config (all packages are on nuget, no need to reference myget)-No need to reference packages which are inside Core, from the projects consuming Core.
-Remove copywrite headers, per Steve Ickman
Task Item
closes #6509