fix: get microsoftAppPassword from profile appPasswordHint #6471

VanyLaw · 2021-03-18T08:46:27Z

Description

get microsoftAppPassword from profile appPasswordHint, update the generated profile when create from abs.

Task Item

#minor

Screenshots

luhan2017 · 2021-03-19T02:46:37Z

Composer/packages/client/src/pages/publish/Publish.tsx

        token = await AuthClient.getARMTokenForTenant(tenant);
      }
    }
+    // get keyvault token


remove this part.

Composer/packages/server/src/externalContentProvider/azureBotServiceProvider.ts

Composer/packages/client/src/utils/electronUtil.ts

Composer/packages/client/src/pages/publish/Publish.tsx

Composer/packages/client/src/utils/electronUtil.ts

Composer/packages/server/src/externalContentProvider/powerVirtualAgentsProvider.ts

Composer/packages/server/src/externalContentProvider/externalContentProvider.ts

Composer/packages/server/src/services/auth/electronAuthProvider.ts

coveralls · 2021-03-24T21:12:00Z

Coverage decreased (-0.1%) to 52.165% when pulling 3d2c68b on wenyluo/kv into 1503c58 on main.

cwhitten · 2021-03-25T00:24:06Z

@VanyLaw @luhan2017 I'm trying to test this and I'm seeing the following behavior:

I don't see @alanlong9278 's dialog that was merged
No publishing profile is created
I can't publish back to Azure

luhan2017 · 2021-03-25T09:48:18Z

No publishing profile is created

Did you set COMPOSER_ENABLE_ONEAUTH=true in your build pipeline? I can't reproduce this issue in my side, the issue could because the oauth is not set correctly so, it failed to get the keyvault and generate the profile.

cwhitten · 2021-03-25T13:28:34Z

No publishing profile is created

Did you set COMPOSER_ENABLE_ONEAUTH=true in your build pipeline? I can't reproduce this issue in my side, the issue could because the oauth is not set correctly so, it failed to get the keyvault and generate the profile.

Yes, it was set as I used the main mac build/signing pipeline.

…k-Composer into wenyluo/kv

boydc2014 · 2021-03-26T00:06:58Z

fix the ci
testing the scenario with an existing name?

luhan2017 · 2021-03-26T06:46:53Z

@cwhitten , The ut and notification issue is fixed now.
But we can't reproduce the alias not working issue as you mentioned before. Could you please help to figure out the reproduceable steps and check if there is anything wrong in data.json. I did see this issue once, and I found that it because there are multiple bots associated with the same bot (which is probably because in the middle of the implementation, the alias logic changes, so there are some bad data in the data.json), I don't see that again after I fix the data.json.

…#6471) * add key valut token get * add auth before doing kv update * refactor the get alias and generate profile code * add azure key vault logic and set policy process * fix generated profile not work * fix build * add exception handling * fix comments * fix ut * Fix lint, comment-out unusued imports * open modal refactor * alias & profile for open bot * api * fix lint * alias * set alias * Fix lint * ut * publish notification Co-authored-by: Qi Kang <kangqidev@gmail.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Chris Whitten <christopherwhitten@gmail.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: Dong Lei <donglei@microsoft.com>

VanyLaw and others added 7 commits March 10, 2021 15:13

add key valut token get

8279a27

add auth before doing kv update

74e9e37

Merge remote-tracking branch 'origin/main' into wenyluo/kv

30b9550

refactor the get alias and generate profile code

b657efa

add azure key vault logic and set policy process

e88b616

Merge remote-tracking branch 'origin/main' into wenyluo/kv

8b0607c

fix generated profile not work

5233813

VanyLaw requested review from GeoffCoxMSFT, a-b-r-o-w-n, beyackle, boydc2014, cwhitten, hatpick, srinaath and tonyanziano as code owners March 18, 2021 08:46

VanyLaw and others added 3 commits March 18, 2021 16:48

Merge remote-tracking branch 'origin/main' into wenyluo/kv

71a08d2

fix build

c111827

Merge branch 'main' into wenyluo/kv

6c8d54d

luhan2017 reviewed Mar 19, 2021

View reviewed changes

github-actions bot assigned luhan2017 Mar 19, 2021

luhan2017 reviewed Mar 19, 2021

View reviewed changes

Composer/packages/server/src/externalContentProvider/azureBotServiceProvider.ts Show resolved Hide resolved

Merge branch 'main' into wenyluo/kv

5aa5029

tonyanziano suggested changes Mar 23, 2021

View reviewed changes

github-actions bot assigned tonyanziano Mar 23, 2021

luhan2017 and others added 6 commits March 24, 2021 09:21

Merge branch 'main' into wenyluo/kv

1bd9bcc

add exception handling

f174450

fix conflict

b710e8b

fix comments

ae3d1d5

Merge branch 'main' into wenyluo/kv

5046984

fix ut

6b1ab1a

Fix lint, comment-out unusued imports

b23b8cf

cwhitten dismissed tonyanziano’s stale review via b23b8cf March 24, 2021 20:03

Merge branch 'main' into wenyluo/kv

4356c9a

open modal refactor

8f79355

luhan2017 and others added 5 commits March 25, 2021 17:50

Merge branch 'main' into wenyluo/kv

92d63a2

alias & profile for open bot

a1d0702

api

c9f068a

fix lint

b8065d7

alias

df11d27

alanlong9278 and others added 5 commits March 25, 2021 21:35

set alias

07d1e2d

Merge branch 'wenyluo/kv' of https://github.com/microsoft/BotFramewor…

f97204e

…k-Composer into wenyluo/kv

Fix lint

8c92548

Merge branch 'main' into wenyluo/kv

7f561b0

Merge branch 'main' into wenyluo/kv

995466c

alanlong9278 and others added 3 commits March 26, 2021 11:17

ut

1fa075e

publish notification

d17bbbc

Merge branch 'main' into wenyluo/kv

3d2c68b

cwhitten approved these changes Mar 26, 2021

View reviewed changes

cwhitten merged commit d0ce8fe into main Mar 26, 2021

cwhitten deleted the wenyluo/kv branch March 26, 2021 16:41

github-actions bot assigned cwhitten Mar 26, 2021

luhan2017 mentioned this pull request Mar 31, 2021

Get Keyvault Password Value #6202

Closed

cwhitten mentioned this pull request May 20, 2021

release: 2.0.0 #7871

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: get microsoftAppPassword from profile appPasswordHint #6471

fix: get microsoftAppPassword from profile appPasswordHint #6471

Uh oh!

VanyLaw commented Mar 18, 2021

Uh oh!

luhan2017 Mar 19, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Mar 24, 2021 •

edited

Loading

Uh oh!

cwhitten commented Mar 25, 2021

Uh oh!

luhan2017 commented Mar 25, 2021

Uh oh!

cwhitten commented Mar 25, 2021

Uh oh!

boydc2014 commented Mar 26, 2021

Uh oh!

luhan2017 commented Mar 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

fix: get microsoftAppPassword from profile appPasswordHint #6471

fix: get microsoftAppPassword from profile appPasswordHint #6471

Uh oh!

Conversation

VanyLaw commented Mar 18, 2021

Description

Task Item

Screenshots

Uh oh!

luhan2017 Mar 19, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Mar 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cwhitten commented Mar 25, 2021

Uh oh!

luhan2017 commented Mar 25, 2021

Uh oh!

cwhitten commented Mar 25, 2021

Uh oh!

boydc2014 commented Mar 26, 2021

Uh oh!

luhan2017 commented Mar 26, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

coveralls commented Mar 24, 2021 •

edited

Loading