Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@liweitian
Copy link
Contributor

@liweitian liweitian commented Aug 1, 2019

Description

This is the first step to refactor lu part. This pr move lu state from settings to lu.state.json

Task Item

Type of change

Please delete options that are not relevant.

  • Code refactor (non-breaking change which improve code quality, clean up, add tests, etc)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have functionally tested my change

Screenshots

Please include screenshots or gifs if your PR include UX changes.

@boydc2014
Copy link
Contributor

Good to see we pick those nits and refactor as a small step one by one. Can you elaborate more about the context, particularly answer those question

  1. what's the current design
  2. what's the issue with current design, why it's a bad design needs to change (usually you can say something are coupled together, which against XXX princinple or make us less flexible to handle the potential scenario change or feature requirement)
  3. what's the new design
    if you answer Init integration with form-editor #2 very clearly, you don't have to talk too much on this question, because you solution should be clear.

@liweitian liweitian closed this Aug 1, 2019
@liweitian
Copy link
Contributor Author

Will open another pr due to code conflict

@liweitian liweitian deleted the liweitian/refineLu branch August 14, 2019 03:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants