This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Get an ARM token only when publishing to Azure #6418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick and
srinaath
as code owners
tonyanziano
changed the title
luhan2017
approved these changes
Mar 16, 2021
lei9444
pushed a commit
that referenced
this pull request
Mar 16, 2021
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
cwhitten
added a commit
that referenced
this pull request
Mar 23, 2021
* release: 1.4.0-rc0 * fix: lg create error with multi-language (#6412) Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> * fix: Remove Attachment Lg template when they are deleted in the Response Editor (#6405) * fix: Remove Attachment Lg template when they are deleted in the Response Editor * strings Co-authored-by: Soroush <sorgh@microsoft.com> * 1.4.0-rc1 * Added gray Composer icon to 'no triggers' dialog state (#6414) Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> * Get an ARM token only when publishing to Azure (#6418) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: composer doesn't see component dialogs that are in subfolders (#6420) * fix: composer doesn't see component dialogs that are in subfolders * clean unused code * fix: revert yeoman-environment to 2.10.3 from 3.1.0 (#6415) * 1.4.0-rc2 * fix: load feature flags if default keys have changed (#6432) * handle case when default feature flags change If a feature flag is renamed or removed, Composer would fail when updating feature flags. * show app error when feature flags fail to fetch in development Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: use new create flow during add skill if enabled (#6427) * Initial changes for component model add skills flow * Reusing function * Add new bot as skill working e2e in component model creation * cleaning up PR * removing unused imports * - fixing typos - enabling qna template to be instantiated as a skill * Fixing title in addSkills modal and fixing default template * fix useEffect Co-authored-by: Patrick Volum <pavolum@microsoft.com> * Update bf-orchestrator to 4.12.0-beta.20210316.cdd0819 (#6435) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: make CSS show triangles in project tree (#6428) Co-authored-by: Andy Brown <asbrown002@gmail.com> * feat: Implement layout to errorCallout (#6396) * implement layout to errorCallout * Fix linting issues Co-authored-by: Andy Brown <asbrown002@gmail.com> * fis: change feature flag text (#6438) Co-authored-by: Patrick Volum <pavolum@microsoft.com> * feat: update runtime package to 4.12.1 (#6441) * Update to 4.12.1 * update schema Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> * fix: hidden showCode button when url is all & show code for form dialog (#6444) * hidden showCode button when dialog is all & show code for form dialog * ci fix * lint Co-authored-by: Dong Lei <donglei@microsoft.com> * Fixing projectId state by ordering state change (#6437) Co-authored-by: Patrick Volum <pavolum@microsoft.com> * prepare changelog for 1.4.0 * 1.4.0-rc3 * feat: take 4.12.2 runtime package (#6469) * take 4.12.2 * Update schema Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> * fix: Allow multiline variations for LG text and speech modalities (#6394) * fix: Allow multiline variations for LG text and speech modalities * fix tests * pr comment Co-authored-by: Soroush <sorgh@microsoft.com> * fix actions (#6476) Co-authored-by: Soroush <sorgh@microsoft.com> * release: 1.4.0 * Update 1.4.0.md * RC4 * Update bf-orchestrator to 4.12.0-beta.20210322.314475a (#6496) Co-authored-by: Chris Whitten <christopherwhitten@gmail.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: TJ Durnford <tjdford@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Ben Brown <benbro@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: taicchoumsft <61705609+taicchoumsft@users.noreply.github.com> Co-authored-by: Christiano Donke <cdonke@users.noreply.github.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com>
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* release: 1.4.0-rc0 * fix: lg create error with multi-language (microsoft#6412) Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> * fix: Remove Attachment Lg template when they are deleted in the Response Editor (microsoft#6405) * fix: Remove Attachment Lg template when they are deleted in the Response Editor * strings Co-authored-by: Soroush <sorgh@microsoft.com> * 1.4.0-rc1 * Added gray Composer icon to 'no triggers' dialog state (microsoft#6414) Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> * Get an ARM token only when publishing to Azure (microsoft#6418) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: composer doesn't see component dialogs that are in subfolders (microsoft#6420) * fix: composer doesn't see component dialogs that are in subfolders * clean unused code * fix: revert yeoman-environment to 2.10.3 from 3.1.0 (microsoft#6415) * 1.4.0-rc2 * fix: load feature flags if default keys have changed (microsoft#6432) * handle case when default feature flags change If a feature flag is renamed or removed, Composer would fail when updating feature flags. * show app error when feature flags fail to fetch in development Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: use new create flow during add skill if enabled (microsoft#6427) * Initial changes for component model add skills flow * Reusing function * Add new bot as skill working e2e in component model creation * cleaning up PR * removing unused imports * - fixing typos - enabling qna template to be instantiated as a skill * Fixing title in addSkills modal and fixing default template * fix useEffect Co-authored-by: Patrick Volum <pavolum@microsoft.com> * Update bf-orchestrator to 4.12.0-beta.20210316.cdd0819 (microsoft#6435) Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> * fix: make CSS show triangles in project tree (microsoft#6428) Co-authored-by: Andy Brown <asbrown002@gmail.com> * feat: Implement layout to errorCallout (microsoft#6396) * implement layout to errorCallout * Fix linting issues Co-authored-by: Andy Brown <asbrown002@gmail.com> * fis: change feature flag text (microsoft#6438) Co-authored-by: Patrick Volum <pavolum@microsoft.com> * feat: update runtime package to 4.12.1 (microsoft#6441) * Update to 4.12.1 * update schema Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> * fix: hidden showCode button when url is all & show code for form dialog (microsoft#6444) * hidden showCode button when dialog is all & show code for form dialog * ci fix * lint Co-authored-by: Dong Lei <donglei@microsoft.com> * Fixing projectId state by ordering state change (microsoft#6437) Co-authored-by: Patrick Volum <pavolum@microsoft.com> * prepare changelog for 1.4.0 * 1.4.0-rc3 * feat: take 4.12.2 runtime package (microsoft#6469) * take 4.12.2 * Update schema Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> * fix: Allow multiline variations for LG text and speech modalities (microsoft#6394) * fix: Allow multiline variations for LG text and speech modalities * fix tests * pr comment Co-authored-by: Soroush <sorgh@microsoft.com> * fix actions (microsoft#6476) Co-authored-by: Soroush <sorgh@microsoft.com> * release: 1.4.0 * Update 1.4.0.md * RC4 * Update bf-orchestrator to 4.12.0-beta.20210322.314475a (microsoft#6496) Co-authored-by: Chris Whitten <christopherwhitten@gmail.com> Co-authored-by: leileizhang <leilzh@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: TJ Durnford <tjdford@gmail.com> Co-authored-by: Soroush <sorgh@microsoft.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Ben Brown <benbro@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: taicchoumsft <61705609+taicchoumsft@users.noreply.github.com> Co-authored-by: Christiano Donke <cdonke@users.noreply.github.com> Co-authored-by: Dong Lei <donglei@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com> Co-authored-by: Long Alan <julong@microsoft.com> Co-authored-by: Soroush <hatpick@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was code in Composer's source that was fetching an ARM token on all publish requests regardless of the publish type, when this should only have been done when publishing to Azure web apps / functions.
This was causing an unnecessary login prompt when trying to publish to PVA after importing.
This is a temporary fix until the code is moved into the Azure publish extensions where it belongs.
Task Item
Fixes #6377