This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Hide deprecated "custom runtime" related features for adaptive rutime #6367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrown
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
Composer/packages/client/src/pages/botProject/runtime-settings/RuntimeSettings.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/botProject/runtime-settings/RuntimeSettings.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/botProject/runtime-settings/RuntimeSettings.tsx
Outdated
Show resolved
Hide resolved
GeoffCoxMSFT
suggested changes
Mar 26, 2021
Member
GeoffCoxMSFT
left a comment
GeoffCoxMSFT
left a comment
There was a problem hiding this comment.
Need to update the isAdaptive dependencies (or useMemo) and consider calling the shared method of isUsingAdaptiveRuntime.
GeoffCoxMSFT
approved these changes
Mar 31, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…utime (microsoft#6367) * Hide deprecated "custom runtime" related features for adaptive rutime * hide ability to change path * fix type * remove lib files * updates * use isusingadpativeruntime * fix usememo syntax
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since new Adaptive Runtime comes pre-ejected, we no longer support the ability to eject, nor do we support the ability to toggle this feature off. All that remains in the runtime control section is the customizable start command that is used when the bot is started. It is very useful for this to remain available as it allows the developer to pass additional options along to the runtime.
Task Item
Fixes #6321
Screenshots
For "old" bots, no change:
For "new" bots, removed features: