This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: updated "Get started" flow available on every page #6365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oser into benbrown/getsmarted
remove get started from bot project settings page
chain modals togethert
benbrown
changed the title
benbrown
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten and
hatpick
as code owners
beyackle
suggested changes
Mar 29, 2021
Contributor
beyackle
left a comment
beyackle
left a comment
There was a problem hiding this comment.
A few minor comments, but mostly this looks good.
Comment on lines
+111
to
+116
| const hasLUIS = | ||
| botProject?.setting?.luis?.authoringKey && botProject?.setting?.luis?.authoringRegion ? true : false; | ||
| const hasQNA = botProject?.setting?.qna?.subscriptionKey ? true : false; | ||
|
|
||
| const hasPublishingProfile = | ||
| botProject?.setting?.publishTargets && botProject?.setting?.publishTargets?.length > 0 ? true : false; |
Contributor
There was a problem hiding this comment.
I'm wary of type-unsafe stuff like this, but in this case I think it's okay - I won't block the PR on it since I think there are no cases where those values could be real but falsey.
| "message": "Clear all" | ||
| }, | ||
| "click_start_and_your_bot_will_be_up_and_running_on_424c29da": { | ||
| "message": "Click start and your bot will be up and running. Once it’s running, you can select “Open in WebChat” to test." |
Contributor
There was a problem hiding this comment.
Hooray for curly quotes in appropriate places!
Composer/packages/client/src/components/ManageQNA/ManageQNA.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/GetStarted/GetStartedTask.tsx
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,680 @@ | |||
| // Copyright (c) Microsoft Corporation. | |||
Contributor
There was a problem hiding this comment.
Agreed. It looks like ManageLuis and ManageQnA share a lot in common, so they could be refactored somehow.
hatpick
previously approved these changes
Mar 31, 2021
beyackle
previously approved these changes
Mar 31, 2021
cwhitten
previously approved these changes
Mar 31, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
) * Enable the get started widget to intelligently determine if LUIS or QNA is needed/configured * define nextsteps as an array that gets rendered * adjsut formating * move get started to top blue bar remove get started from bot project settings page * Add placeholder mvp luis keys modal * add placeholder mvp qna key modal chain modals togethert * introduce ProvisionHandoff component, to display customized instructions for creating azure components * luis widget * updated styles and content for get started * clean up code * add support for qnamaker provisioning * merge main * remove unused css * clean up unused vars * add final confirmation step to luis * updated ux for luis * fix button disabled state * ux fixes for luis * ux fixes for qna * magic teaching bubbs * cleanup * fix weird issue * Wrapping up UI for provisioning hand off modal * revised links and buttons in get started * remove unused styles * improve behavior of teaching bubbles during creation flow * highglight start bot when no steps are left * nav to page when opening modal * remove delete bot from settings page (still in toolbar) * make pane scrollable * delete unused ref * address issue with type mismatch in qna * fix mock * fix test * update syntax for accessing lufiles and qnafiles * address pull request feedback * locale * fix merge conflict Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the first step of allowing the get started widget to intelligently display "Next steps" for a user
This detects the need for LUIS and QNA, then detects whether they are currently configured. This uses the same mechanism as the validation system.
Then, it displays "tasks" in the get started section.
EXPECTED BEHAVIOR:
The panel will only fly out at CREATE time, but the tasks will continue to be present
NOTE: Currently, tasks do not disappear once completed. We are investigating a method for doing this in a sensible manner.
INCLUDES:
Task Item
Fixes #6269
fixes #5827
fixes #6263
Fixes #5896
fixes #6364
fixes #6365
fixes #6546
Screenshots