This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: suggest user defined memory variables in LG files #6334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmicshuai
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
hatpick
reviewed
Mar 10, 2021
Composer/packages/tools/language-servers/language-generation/src/LGServer.ts
Outdated
Show resolved
Hide resolved
Composer/packages/tools/language-servers/language-generation/src/lgParser.ts
Outdated
Show resolved
Hide resolved
…soft/BotFramework-Composer into shuwan/supportVariblesInLG
…soft/BotFramework-Composer into shuwan/supportVariblesInLG
hatpick
approved these changes
Mar 12, 2021
Contributor
Author
|
Since this PR is related to add something in LG worker, it can wait until #5853 is merged. |
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* init * cache variabkes defined in LG files * reduce calculation of variables * remove console log * add find expression by lg parser * change find variables * fix some issues * remove a setimeout func
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6137
Now in LG all up view editor, user wrote some variables like
user.predefined.props, the language server will suggest this variable when user try to enter it again.Here is a short demo. (
user.group.nameis defined is dialog files)Also in this PR, the calculation of memory variables has been refactored, this will reduce the calculation.