This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: added telemetry support to node runtime and adopted missing middlewares #6288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chon219
requested review from
benbrown,
boydc2014,
carlosscastro and
luhan2017
as code owners
Contributor
|
@benbrown should this be included in the upcoming release? Can you be the owner? |
benbrown
reviewed
Mar 9, 2021
chon219
changed the title
Member
|
@benbrown @luhan2017 @chon219 could we get more traction on this PR? |
luhan2017
reviewed
Mar 26, 2021
luhan2017
previously approved these changes
Mar 26, 2021
luhan2017
previously approved these changes
Mar 29, 2021
luhan2017
added a commit
that referenced
this pull request
Apr 6, 2021
…lewares (#6288) * added telemetry support to node runtime * configureTelemetry should be shared by webapp/functions * updated botbuilder packages to 4.12.0 * app insights telemetry should be optional * fixed cases of settings.feature * fixed path of runtime * optional telemetry client * updated package-lock.json Co-authored-by: Ben Brown <benbro@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Merged
benbrown
added a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
…lewares (microsoft#6288) * added telemetry support to node runtime * configureTelemetry should be shared by webapp/functions * updated botbuilder packages to 4.12.0 * app insights telemetry should be optional * fixed cases of settings.feature * fixed path of runtime * optional telemetry client * updated package-lock.json Co-authored-by: Ben Brown <benbro@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
benbrown
added a commit
that referenced
this pull request
Jun 11, 2021
…lewares (#6288) * added telemetry support to node runtime * configureTelemetry should be shared by webapp/functions * updated botbuilder packages to 4.12.0 * app insights telemetry should be optional * fixed cases of settings.feature * fixed path of runtime * optional telemetry client * updated package-lock.json Co-authored-by: Ben Brown <benbro@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…lewares (microsoft#6288) * added telemetry support to node runtime * configureTelemetry should be shared by webapp/functions * updated botbuilder packages to 4.12.0 * app insights telemetry should be optional * fixed cases of settings.feature * fixed path of runtime * optional telemetry client * updated package-lock.json Co-authored-by: Ben Brown <benbro@microsoft.com> Co-authored-by: Lu Han <32191031+luhan2017@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added telemetry support to node runtime and adopted missing middlewares.
Task Item
Fix #5808
Added following middlewares to node runtime as well:
Screenshots