This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: LG template go to definition in language server #6110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
February 25, 2021 16:55
…work-Composer into shuwan/gotoDefinition
…BotFramework-Composer into shuwan/gotoDefinition
cosmicshuai
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
hatpick
suggested changes
Mar 16, 2021
Composer/packages/tools/language-servers/language-generation/src/LGServer.ts
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Mar 16, 2021
Composer/packages/tools/language-servers/language-generation/src/LGServer.ts
Show resolved
Hide resolved
hatpick
suggested changes
Mar 17, 2021
hatpick
previously approved these changes
Mar 24, 2021
hatpick
reviewed
Mar 24, 2021
hatpick
reviewed
Mar 26, 2021
Composer/packages/client/src/pages/language-generation/code-editor.tsx
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Mar 26, 2021
hatpick
suggested changes
Mar 26, 2021
hatpick
approved these changes
Mar 27, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* init * add local file go to definition * remove a console log * fix a test * add jump file notification * add templateId * navigate to lg template defination * change the place of a function call * navigate to lg page on client * change to onNavigateLGPage * fix multilanguage go to incorrect behaviors * remove a log statement * fix signatures * removed logs and resovled conflicts * fix types Co-authored-by: liweitian <liweitian93@outlook.com> Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com> Co-authored-by: Soroush <sorgh@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5522
Add go to definition for LG templates.
While editing LG files, once user hit crtl+right click on a template name call in expression. The editor will bring the cursor to the location where the template is defined.
Features:
Goto Definition in LG all up view
Goto Definition in LG imports
Goto definition in inline LG editor
Goto definition in form dialog
Goto Definition in form dialog imports
