This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
feat: apply new deisgn on project tree to solve Critical create actions inaccessible issue on Project Tree #5722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatpick
suggested changes
Feb 8, 2021
Composer/packages/client/src/components/ProjectTree/AddDialogIcon.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/AddDialogIcon.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/AddDialogIcon.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/AddTriggerIcon.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/AddTriggerIcon.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/AddTriggerIcon.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/ProjectTree.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/treeItem.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/components/ProjectTree/treeItem.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
As for the two svg Icons you are creating, I highly recommend looking into this:
from fabric. Considering you have the svg code for the icons you can do this: now you can use MyIcon like <MyIcon style={ any style of type React.CSSProperties} /> |
Contributor
Author
all comments handled |
hatpick
previously approved these changes
Feb 9, 2021
boydc2014
previously approved these changes
Feb 9, 2021
boydc2014
approved these changes
Feb 10, 2021
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…ns inaccessible issue on Project Tree (microsoft#5722) * save for tmp use * save tmp code * save for tmp use * add two more buttons * update calculation for treeitem text maxwidth * show parent icons if a link selected * fix resize bug * fix resize bug * remove unused file * handle comments * fix truncated treeitem width bug * remove addTrigger and addDialog Icons Co-authored-by: Dong Lei <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
apply new design on project tree without the addTrigger and addDialog icons
https://www.figma.com/file/deFhMPBnRWxTYiYDYqYxrc/Composer-Vivek?node-id=10809%3A0
and
solve a bug on resizing the project window.
It does not re-render when resizing because the "leftSplitWidth" is not passed into the an useCallback function as a dependency. So some very long name dialog is still hidden after expanding the window.
Task Item
Closes #5681
Screenshots