This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Pass access token for publishing through request body instead of header #5700
+10
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyanziano
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
cwhitten,
hatpick and
srinaath
as code owners
tonyanziano
changed the title
tonyanziano
changed the title
a-b-r-o-w-n
approved these changes
Feb 4, 2021
Contributor
a-b-r-o-w-n
left a comment
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
Approved, but I have 1 question.
tonyanziano
added a commit
that referenced
this pull request
Feb 9, 2021
… header (#5700) Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Andy Brown <[email protected]>
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
… header (microsoft#5700) Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Andy Brown <[email protected]>
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
… header (#5700) Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Andy Brown <[email protected]>
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
… header (microsoft#5700) Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Andy Brown <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to a limitation in the version of NodeJS that Composer runs on (< 13), requests sent to the server are limited to a header size of 8 KB. This limitation was blocking Azure publishing and provisioning requests from the client to the server, which was ultimately preventing publishing from happening in certain cases where the Bearer token received from Azure was larger than 8 KB.
This threshold can be increased manually by starting Composer with the environment variable of
NODE_OPTIONSset to"--max-http-header-size=16000".This fix resolves that issue by embedding the access token in the body of the request from the client to the server, instead of in the Authorization header. This should bypass the limitation and allow Composer's server to make Azure publishing requests on behalf of the client using the provided token.
Task Item
fixes #5650