Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@lei9444
Copy link
Contributor

@lei9444 lei9444 commented Feb 3, 2021

Description

in this PR

  1. When all languages are not supported by luis service, prevent user to start bot and show error in diagnostic page.
  2. When parts of the languages are not supported, show warning in diagnostic page, and show notifications when start bot.

Task Item

closes #5495
closes #5702

Screenshots

luis error

@coveralls
Copy link

coveralls commented Feb 5, 2021

Coverage Status

Coverage decreased (-0.01%) to 55.077% when pulling f4cff5f on lei9444:lubuildfix into 2010f0f on microsoft:main.

boydc2014
boydc2014 previously approved these changes Feb 5, 2021
@boydc2014 boydc2014 merged commit b83c152 into microsoft:main Feb 7, 2021
lei9444 added a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…ish (microsoft#5688)

* fix: No exception thrown when unsupported locale is set for Luis publish

* fix unit tests

* filter unsupport language when create cross train config

Co-authored-by: Dong Lei <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

3 participants