This repository was archived by the owner on Jul 9, 2025. It is now read-only.
perf: avoid multi re-rendering when switch the project tree item (step 2) #5673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
boydc2014
approved these changes
Feb 5, 2021
Closed
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…p 2) (microsoft#5673) * use designPage only * add router for link * remove unused code * add empty check Co-authored-by: Srinaath Ravichandran <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1. multi re-render
When we switch the tree item from project tree, we will update the recoil state and the reach/router will also update its context. These two will trigger twice re-render.
fix
All design page components only consume the designPageLocation state(recoil state). Add React.memo to check props change, and memorize the result.
2. remove CloneDeep
The clonedeep in visual editor will take about 80ms when switch the dialog. implement it in other way, and the time reduce to 0.3ms
3. The links in sideBar will call setState 9 times
The < Link /> don't have a root provider, so all < Link /> will call setState.
fix
Add a root provider for these < Link />, they will use the same context
Task Item
closes #5559 #4214 #3022
Screenshots