This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
fix: text input cursor err in runtime section #5636
Merged
luhan2017
merged 16 commits into
microsoft:main
from
alanlong9278:julong/text-err-runtime-section
Feb 8, 2021
Merged
fix: text input cursor err in runtime section #5636
luhan2017
merged 16 commits into
microsoft:main
from
alanlong9278:julong/text-err-runtime-section
Feb 8, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@tomlm this is what was happening to you the other day!! glad to see it fixed. |
liweitian
suggested changes
Feb 1, 2021
Composer/packages/client/src/pages/botProject/runtime-settings/RuntimeSettings.tsx
Show resolved
Hide resolved
hatpick
reviewed
Feb 2, 2021
Composer/packages/client/src/pages/botProject/runtime-settings/RuntimeSettings.tsx
Outdated
Show resolved
Hide resolved
…alanlong9278/BotFramework-Composer into julong/text-err-runtime-section
liweitian
approved these changes
Feb 8, 2021
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix cursor err * refactor code style with other property * lint * use type Co-authored-by: Dong Lei <[email protected]> Co-authored-by: Lu Han <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bugfix: Text input jumps to last character after adding characters as first character under runtime section.
Reason: The value of
textFieldis the props value, so the field component will be refresh after updating the props value.Solution:Set value as state value.
Task Item
closes #5437
Screenshots
Wrong behavior

Expected behavior
