This repository was archived by the owner on Jul 9, 2025. It is now read-only.
chore: Hide triggers 'OnQnAMatch' and 'OnChooseIntent' in PVA env #5619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
a-b-r-o-w-n
approved these changes
Jan 27, 2021
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…crosoft#5619) Co-authored-by: Andy Brown <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#minor
In #4079, the TriggerCreationModal becomes completely schema-driven, a small piece of PVA-only code was removed.
It will cause an issue, in PVA env, two triggers be visible to users but not available in PVA env:
Microsoft.OnQnAMatchaka 'QnA Intent recognized'Microsoft.OnChooseIntentaka 'Duplicated intents recognized'This PR forces these two triggers to be hidden when the env is detected as the PVA env.
Notes:
I was considering that updating the
app.uischemaon PVA side, however, it only affects newly created skills but won't work for existing skills.On the other hand, an update on PVA's app.uischema is still required, will follow up with @tonyanziano.
Task Item
Screenshots