This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Move persistence layer's delta computation into worker #5563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
Contributor
|
I can see the perf gain here, just one more question, do we know why after moving to worker, we still take about 10ms? |
Contributor
Author
The worker.postMessage will take some time here, postMessage its own will do some clone algorithm. I tried to use JSON.stringify our data, but looks like the JSON.stringify will take more time. |
Contributor
|
This is awesome work @lei9444 ! Moving it a worker is so much better. |
srinaath
previously approved these changes
Jan 24, 2021
srinaath
reviewed
Jan 24, 2021
srinaath
reviewed
Jan 24, 2021
boydc2014
approved these changes
Jan 25, 2021
alanlong9278
added a commit
that referenced
this pull request
Jan 25, 2021
* main: Update numberinput.dialog (#5575) fix hover display incorrect returntype (#5588) fix: Move persistence layer's delta computation into worker (#5563) fix: electron update error (#5573) fix: showing correct error message in local publish (#5509) feat: change source of packages from local feed to live npm/nuget feed (#5516) set max http header size to fix 431 (#5521) Updating to daily runtime for R12 development (#5529) fix: correctly generate l10n files when using zsh (#5555) chore: deprecate feature request issue template (#5378) fix: designPage navigation to settings Page url error (#5546) fix: luis\qna key missing in skill bot (#5545) delete trigger by projectId passed from projectTree (#5542)
Closed
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…t#5563) * fix: Move persistence layer's delta computation into worker * fix unit testsa * fix tests * fix tests * add test coverage * update naming Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The persistence layer will check files' change after the state changed. When we use a big bot such as the calendarSkill, the check function will block the main thread about 90ms every notify.
fix
Move the complex computation to worker
Task Item
closes #5561
Screenshots
before:
after:
