This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Merge settings error #5539
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinaath Ravichandran <srravich@microsoft.com>
srinaath
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick and
tonyanziano
as code owners
a-b-r-o-w-n
approved these changes
Jan 17, 2021
Contributor
|
The mergedSettings represents what a skill's bot has. If it does not have a key, then in the settings page, it will display nothing and says this bot is using root bot's key. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the root bot's keys are not propogated into the skills and we notice an error that the key is missing in the skill even though the key is available in the root bot.
Fixes #minor