This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: add check script for l10n files #5528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyackle
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
boydc2014,
cwhitten,
hatpick and
srinaath
as code owners
tonyanziano
reviewed
Jan 14, 2021
| const fs = require('fs'); | ||
| const path = require('path'); | ||
|
|
||
| const localePath = 'packages/server/src/locales'; |
Contributor
There was a problem hiding this comment.
does this need to be normalized for Windows?
Contributor
Author
There was a problem hiding this comment.
I'm running this on a Windows machine and it worked fine.
tonyanziano
approved these changes
Jan 14, 2021
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* add check script for l10n files * Update l10nCheck.js * Update fr.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add a new "l10nCheck" script and associated yarn command which will inspect the locale files in
packages/server/src/localesand find issues that tend to occur in them:') between letters; single quotes are semantic to ICU formatting and should be replaced by curly quotes in actual messagesThis won't catch every possible issue, but it should be used as a starting point to find the most common errors.
Task Item
refs #5496