This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: l18n apostrophe errors #5515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyackle
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
tonyanziano
previously approved these changes
Jan 13, 2021
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
What generates these translations? If it's a script, can we modify the script to avoid inserting these double quotes so that we can prevent breaks like this from happening again?
Contributor
Author
|
@tonyanziano |
tonyanziano
approved these changes
Jan 13, 2021
lei9444
pushed a commit
that referenced
this pull request
Jan 14, 2021
* fix some l18n apostrophe errors * Curlify quotes * fix issues in l18n files
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* fix some l18n apostrophe errors * Curlify quotes * fix issues in l18n files
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* fix some l18n apostrophe errors * Curlify quotes * fix issues in l18n files
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* fix some l18n apostrophe errors * Curlify quotes * fix issues in l18n files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of our locale files had quote marks in places that broke ICU formatting. This should fix those.
Task Item
fixes #5496