Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: telemetry fixes #5493

Merged
boydc2014 merged 9 commits into from
Jan 13, 2021
Merged

fix: telemetry fixes #5493

boydc2014 merged 9 commits into from
Jan 13, 2021

Conversation

@tdurnford
Copy link
Collaborator

@tdurnford tdurnford commented Jan 11, 2021 •
edited
Loading

Description

  • Enable the capture of the help link URL
  • Fix the unknown section for pageviews
  • Replace the URL captured for the section page views with the section name. Right now we are capturing the actual URLs which could contain sensitive data as they contain dialog names.

Task Item

#minor

hatpick
hatpick reviewed Jan 12, 2021
View reviewed changes
@coveralls
Copy link

coveralls commented Jan 12, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 54.901% when pulling 1b0de65 on tdurnford:fix/telemetry into 8923e14 on microsoft:main.

@tdurnford tdurnford changed the title telemtry fixes fix: telemtry fixes Jan 12, 2021
@tdurnford tdurnford changed the title fix: telemtry fixes fix: telemetry fixes Jan 12, 2021
@GeoffCoxMSFT
Copy link
Member

GeoffCoxMSFT commented Jan 12, 2021

Reran the conventional PR job for you :)

a-b-r-o-w-n
a-b-r-o-w-n reviewed Jan 12, 2021
View reviewed changes
Composer/packages/client/src/utils/getPageName.tsx
[PageNames.Design]: /\/dialogs/i,
[PageNames.Home]: /\/home/i,
[PageNames.Design]: /\/dialogs|\/bot\/d+.d+/i,
[PageNames.Home]: /\/|\/home|\/projects\/create|\/projects\/open/i,
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this now includes project creation? Would it be better to separate the project creation pages into it's own page category?

Copy link
Collaborator Author

@tdurnford tdurnford Jan 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per a conversation with @garypretty, since we are already capturing custom events for /project/create and /projects/open it would be redundant to capture them as a page view.

@boydc2014
Copy link
Contributor

boydc2014 commented Jan 13, 2021

@garypretty can you confirm do we want to include this in 1.3 patch?

@boydc2014 boydc2014 merged commit c7a9322 into microsoft:main Jan 13, 2021
@tdurnford tdurnford deleted the fix/telemetry branch January 14, 2021 00:32
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@tdurnford @boydc2014
fix: telemetry fixes (microsoft#5493)
82ea4ab 
* telemtry fixes

* remove duplicate code

Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@cwhitten cwhitten Awaiting requested review from cwhitten

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

2 more reviewers

@hatpick hatpick hatpick left review comments

@a-b-r-o-w-n a-b-r-o-w-n a-b-r-o-w-n left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.3Patch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tdurnford @coveralls @GeoffCoxMSFT @boydc2014 @hatpick @a-b-r-o-w-n