This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: LG Editor dropping changes #4997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhixzhan
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
boydc2014
approved these changes
Nov 29, 2020
boydc2014
pushed a commit
that referenced
this pull request
Nov 29, 2020
* if changes happen on common.lg, async re-parse all. * update test
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* if changes happen on common.lg, async re-parse all. * update test
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* if changes happen on common.lg, async re-parse all. * update test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug introduced in #4669, root caused is a long time LG parsing. when editing common.lg, all LG files in this bot will be parse again. when the bot has many lgFiles or some of them is large. The time of re-parsing them could be seconds.
at this moment, if go to another page, composer is reading a middle state, which cause a mangled editing version in LG Editor.
Fix it by split re-parse all to another async thread.
Task Item
close #4988
Screenshots