Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: a11y in all-up view #4991

Merged
cwhitten merged 3 commits into from
Nov 30, 2020
Merged

fix: a11y in all-up view #4991

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27b9a6a
keyboard Enter submit
zhixzhan Nov 26, 2020
f8e5ae9
Merge branch 'main' into zhixzhan/all-up-view-a11y
boydc2014 Nov 30, 2020
64b3172
Merge branch 'main' into zhixzhan/all-up-view-a11y
a-b-r-o-w-n Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Composer/packages/client/src/components/EditableField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,12 @@ const EditableField: React.FC<EditableFieldProps> = (props) => {
fieldRef.current?.blur();
};

// single line, press Enter to submit
// multipe line, press Enter to submit, Shift+Enter get a new line,
const handleOnKeyDown = (e) => {
if (e.key === 'Enter' && expanded) {
const enterOnField = e.key === 'Enter' && hasFocus;
const multilineEnter = multiline ? !e.shiftKey : true;
if (enterOnField && multilineEnter) {
handleCommit();
}
if (e.key === 'Escape') {
Expand Down