Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Nov 18, 2020

Description

Previously, questions are all rendered, even rows are collapsed, expand is set question components 'hide'/'show'. That cause perf issue when QnA is large. benchmark from low performance laptop:

  1. when table list first page ( top 10 QnA pairs ), questions amount more than 1000, scroll on list will feel 1s delay.
  2. when questions amount less than 500, UX still feel smoothy.
  3. when each pairs don't have much alternative questions, more than 10000 line qna file still smooth, UX works fine.

So the bottleneck is rendered too many hide question components in viewport. and the amount of QnA pairs will not cause perf issue.

Fix it by render only one question when row collapsed.

Task Item

close #4849

Screenshots

image

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 54.461% when pulling 71a93b9 on zhixzhan/qnalist-perf-fix into abce2a7 on main.

@boydc2014 boydc2014 merged commit 5d6c709 into main Nov 18, 2020
@boydc2014 boydc2014 deleted the zhixzhan/qnalist-perf-fix branch November 18, 2020 13:54
lei9444 pushed a commit that referenced this pull request Nov 20, 2020
boydc2014 pushed a commit that referenced this pull request Nov 20, 2020
* lazy render qna hidden list item (#4871)

* fix: lg api use the wrong offset on the original file (#4892)

Co-authored-by: Zhixiang Zhan <zhixzhan@microsoft.com>
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Composer is very slow with 2 chit-chats Q&A

4 participants