This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: Add data collection dialog and settings #4864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
hatpick
reviewed
Nov 18, 2020
Composer/packages/client/src/recoilModel/dispatchers/serverSettings.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/setting/app-settings/AppSettings.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/recoilModel/dispatchers/serverSettings.tsx
Outdated
Show resolved
Hide resolved
hatpick
suggested changes
Nov 18, 2020
hatpick
approved these changes
Nov 18, 2020
EricDahlvang
pushed a commit
that referenced
this pull request
Nov 27, 2020
* feat: Add data collection dialog and settings * small changes * remove console.log * fix log message * fix type
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* feat: Add data collection dialog and settings * small changes * remove console.log * fix log message * fix type
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* feat: Add data collection dialog and settings * small changes * remove console.log * fix log message * fix type
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* feat: Add data collection dialog and settings * small changes * remove console.log * fix log message * fix type
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a prompt when the user opens the app to opt-in or opt-out of data collection. It also adds the ability for them to change their data collection preferences in the Application Settings.
Task Item
Closes #4766
Closes #4767
Screenshots
Data Collection Dialog
Data Collection Application Settings