This repository was archived by the owner on Jul 9, 2025. It is now read-only.
chore: add missing type declarations in 'useDialogEditApi' #4801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeze322
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
a-b-r-o-w-n
approved these changes
Nov 13, 2020
EricDahlvang
pushed a commit
that referenced
this pull request
Nov 27, 2020
* fix async move * add type declarations for useDialogEditApi * fix ts type Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
…#4801) * fix async move * add type declarations for useDialogEditApi * fix ts type Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* fix async move * add type declarations for useDialogEditApi * fix ts type Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…#4801) * fix async move * add type declarations for useDialogEditApi * fix ts type Co-authored-by: Soroush <hatpick@gmail.com> Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com> Co-authored-by: Andy Brown <asbrown002@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #4800
Prevent potential uncaptured async return value usage bugs. Can prevent unexpected value type:
Task Item
Screenshots