This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: do not stub __dirname for node extensions #4749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinaath
approved these changes
Nov 10, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Nov 12, 2020
* settingsPage: remove useless files Corrected types Support undo/redo for skill (microsoft#4754) fix UT feat: Diagnostics Page (microsoft#4457) set defaultLanguage as active language if active language is deleted fix: correct URL when switching page modes (microsoft#4736) fix: do not stub __dirname for node extensions (microsoft#4749) chore: bundle extensions (microsoft#4745) fix: Delete & Undo on actions with LG templates doesn't bring back the LG content (microsoft#4740) feat: update sdk package to 4.11.0 (microsoft#4741)
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows node extensions bundled by webpack to use
__dirnameappropriately.Task Item
#minor