This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: Added languages to dropdown in settings #4738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffCoxMSFT
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
beyackle
suggested changes
Nov 10, 2020
Contributor
beyackle
left a comment
beyackle
left a comment
There was a problem hiding this comment.
Looks good, just one tiny change needed.
Composer/packages/client/src/pages/setting/app-settings/AppSettings.tsx
Outdated
Show resolved
Hide resolved
boydc2014
reviewed
Nov 10, 2020
Composer/packages/client/src/pages/setting/app-settings/AppSettings.tsx
Outdated
Show resolved
Hide resolved
hatpick
reviewed
Nov 10, 2020
| const renderElectronSettings = isElectron(); | ||
|
|
||
| const languageOptions = [{ key: 'en-US', text: formatMessage('English (US)') }]; | ||
| const languageOptions = [ |
Contributor
There was a problem hiding this comment.
This can be moved to the outside of the component code.
beyackle
previously approved these changes
Nov 10, 2020
beyackle
approved these changes
Nov 10, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Added languages to dropdown in settings * Fixed typo in zh-Hant key * Moved englishName to comments * log over error to allow tests to run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 17 supported languages need to be in the dropdown.
Task Item
Fixed #4737
Screenshots