Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@LouisEugeneMSFT
Copy link
Contributor

Description

  • Adding ability to switch to an expression from an OpenObjectField when the schema permits it.
  • Showing OpenObjectField when additionalProperties is an object, not any truthy value.

Task Item

closes #4599

Screenshots

image

@LouisEugeneMSFT LouisEugeneMSFT changed the title Leugene/issue4599 fix: Add ability to switch to expression when editing an "OpenObjectField" (object with additionalProperties) & only show OpenObjectField when additionalProperties is an object Oct 30, 2020
tdurnford
tdurnford previously approved these changes Oct 30, 2020
@cwhitten
Copy link
Member

cwhitten commented Nov 2, 2020

@LouisEugeneMSFT please fix the unit tests:

FAIL packages/adaptive-form/src/utils/tests/resolveFieldWidget.test.ts (6.783 s)
● resolveFieldWidget › type: object › returns OpenObjectField when additional properties are allowed

expect(received).toEqual(expected) // deep equality

Expected: [Function OpenObjectField]
Received: [Function anonymous]

  220 | 
  221 |       const { field: ReturnedField } = resolveFieldWidget({ schema });
> 222 |       expect(ReturnedField).toEqual(DefaultFields.OpenObjectField);
      |                             ^
  223 |     });
  224 |   });
  225 | 

  at Object.toEqual (src/utils/__tests__/resolveFieldWidget.test.ts:222:29)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 55.14% when pulling c0bceb3 on leugene/issue4599 into 8589c32 on main.

@cwhitten cwhitten merged commit 2031750 into main Nov 2, 2020
@cwhitten cwhitten deleted the leugene/issue4599 branch November 2, 2020 19:48
luhan2017 pushed a commit that referenced this pull request Nov 3, 2020
…ield" (object with additionalProperties) & only show OpenObjectField when additionalProperties is an object (#4600)

* fix

* fix

* updating test

Co-authored-by: Chris Whitten <[email protected]>
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…ield" (object with additionalProperties) & only show OpenObjectField when additionalProperties is an object (microsoft#4600)

* fix

* fix

* updating test

Co-authored-by: Chris Whitten <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

5 participants