This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Add form-wide and better trigger grouping #4537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffCoxMSFT
requested review from
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
GeoffCoxMSFT
changed the title
hatpick
reviewed
Oct 26, 2020
| const isValidProperty = validProperties | ||
| ? (x: string | undefined) => x && validProperties.findIndex((p) => x === p) !== -1 | ||
| ? (x: string | undefined) => | ||
| x && (x === NoGroupingTriggerGroupName || validProperties.findIndex((p) => x === p) !== -1) |
Contributor
There was a problem hiding this comment.
nit: replace indexOf with includes
hatpick
previously approved these changes
Oct 26, 2020
hatpick
approved these changes
Oct 26, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Add form-wide and better trigger grouping * Fix double import from merge * PR fix
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Triggers w/o properties were missing, this now provides the form-wide group
Updated to include expectedProperties in property search
Task Item
Fixes #4534
Screenshots