Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@zidaneymar
Copy link
Contributor

@zidaneymar zidaneymar commented Oct 26, 2020

Description

Before showing "Test In Emulator", check if the port in use already

Task Item

fixes #3728

Screenshots

@coveralls
Copy link

coveralls commented Oct 26, 2020

Coverage Status

Coverage decreased (-0.008%) to 55.389% when pulling 0e85e51 on qika/checkConnection into ea34b18 on main.

@a-b-r-o-w-n a-b-r-o-w-n added the 1.3 1.3 Release label Nov 13, 2020
@cwhitten
Copy link
Member

@zidaneymar please fix tests

@zidaneymar
Copy link
Contributor Author

@zidaneymar please fix tests

I have fixed the ut and resolved the conflicts.

@cwhitten cwhitten merged commit ae344cd into main Nov 30, 2020
@cwhitten cwhitten deleted the qika/checkConnection branch November 30, 2020 20:48
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
…lishing (microsoft#4521)

* check if port in use before showing success message on local publishing

* change to dev dependency

* fix build error

Co-authored-by: Chris Whitten <[email protected]>
Co-authored-by: Andy Brown <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

1.3 1.3 Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test in Emulator becomes active before bot is actually ready to accept connections

5 participants