This repository was archived by the owner on Jul 9, 2025. It is now read-only.
chore: update server api to prevent overwrite the root dialog #4520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
boydc2014
approved these changes
Oct 26, 2020
Contributor
|
What is the reason for this change? I don't see a linked issue. |
Member
|
@a-b-r-o-w-n this is something I worked with Dong and Leilei on for a PVA requirement |
Contributor
|
This probably warrants some commenting in the code because our code base isn't directly using this parameter. |
Member
|
I'm going to implement the client-side of this and will be sure to include some comments. |
Contributor
|
We should also consider typing the request body on our controller actions like in https://github.com/microsoft/BotFramework-Composer/blob/main/Composer/packages/server/src/controllers/extensions.ts#L55 We can then add comments on the TS properties. |
Merged
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…oft#4520) Co-authored-by: Dong Lei <[email protected]> Co-authored-by: Chris Whitten <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add preserveRoot to inform create project to not overwrite the root dialog
Task Item
#minor
Screenshots