Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: avoid creating duplicate QNA match trigger #4518

Merged
boydc2014 merged 7 commits into from
Oct 27, 2020
Merged

fix: avoid creating duplicate QNA match trigger #4518

boydc2014 merged 7 commits into from
Oct 27, 2020

Conversation

@zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Oct 26, 2020 •
edited
Loading

Description

  1. Remove pre-created resource from bot template.
  2. Add check existed QnA Trigger, avoid duplicates.

Task Item

close #4512

Screenshots

@coveralls
Copy link

coveralls commented Oct 26, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 55.009% when pulling 99d84a4 on zhixzhan/qna-fix into 4d113c8 on main.

@boydc2014
Copy link
Contributor

boydc2014 commented Oct 26, 2020

Besides fixing the pre-setup of the bot sample, we also need to update the logic to avoid creating duplicate trigger by default, right?

@boydc2014 boydc2014 self-assigned this Oct 26, 2020
@zhixzhan
Copy link
Contributor Author

zhixzhan commented Oct 26, 2020

Besides fixing the pre-setup of the bot sample, we also need to update the logic to avoid creating duplicate trigger by default, right?

Yes, I asked Lu, we don't need create duplicate trigger every time, I'm going to revert changes in bot sample, add a check before create trigger.

@zhixzhan
Copy link
Contributor Author

zhixzhan commented Oct 26, 2020

Besides fixing the pre-setup of the bot sample, we also need to update the logic to avoid creating duplicate trigger by default, right?

Yes, I asked Lu, we don't need create duplicate trigger every time, I'm going to revert changes in bot sample, add a check before create trigger.

I still removed the pre-created code from sample bot, that will keep new created bot always fresh.

@a-b-r-o-w-n
Copy link
Contributor

a-b-r-o-w-n commented Oct 26, 2020

@zhixzhan can you provide a more descriptive title for this pull request?

@zhixzhan zhixzhan changed the title fix: QnA authoring issue fix: QnA create duplicate intent trigger Oct 26, 2020
@zhixzhan zhixzhan changed the title fix: QnA create duplicate intent trigger fix: Add QnA create duplicate intent trigger Oct 26, 2020
@zhixzhan
Copy link
Contributor Author

zhixzhan commented Oct 26, 2020

@zhixzhan can you provide a more descriptive title for this pull request?

Sure, updated, sorry for that.

@boydc2014 boydc2014 changed the title fix: Add QnA create duplicate intent trigger fix: avoid creating duplicate QNA match trigger Oct 27, 2020
@boydc2014 boydc2014 merged commit 1481a2f into main Oct 27, 2020
@boydc2014 boydc2014 deleted the zhixzhan/qna-fix branch October 27, 2020 09:48
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@zhixzhan @boydc2014
fix: avoid creating duplicate QNA match trigger (microsoft#4518)
792dbdb 
* update qna sample bot

* check existed qna trigger before add

Co-authored-by: Dong Lei <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@cwhitten cwhitten Awaiting requested review from cwhitten

@beyackle beyackle Awaiting requested review from beyackle

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

1 more reviewer

@boydc2014 boydc2014 boydc2014 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@boydc2014 boydc2014

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

QnA authoring issues

5 participants

@zhixzhan @coveralls @boydc2014 @a-b-r-o-w-n