Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@zxyanliu
Copy link
Contributor

@zxyanliu zxyanliu commented Oct 23, 2020

Description

Before

image
image

Task Item

#4448
#minor

Screenshots

After

qna-1

Copy link
Contributor

@beyackle beyackle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should have the yarn l10n script run and the resulting changes to en-US.json committed alongside it.

@zxyanliu
Copy link
Contributor Author

beyackle
This PR should have the yarn l10n script run and the resulting changes to en-US.json committed alongside it.

That's a great point, Ben! Thanks for bringing it up!
I will update it.

@coveralls
Copy link

coveralls commented Oct 23, 2020

Coverage Status

Coverage remained the same at 55.297% when pulling 7860243 on zxyanliu/errorMessage/20201022 into 032f17a on main.

@zxyanliu zxyanliu changed the title fix: Error message in QnA KB creation fix: error message in QnA KB creation Oct 23, 2020
@zxyanliu
Copy link
Contributor Author

zxyanliu commented Oct 23, 2020

@beyackle FYI.
As you suggested, I ran the yarn l10n script and committed the resulting changes to en-US.json.
But why am I seeing more changes to the en-US file than what I updated? Please take a look.

@zxyanliu zxyanliu linked an issue Oct 23, 2020 that may be closed by this pull request
@zxyanliu zxyanliu requested a review from beyackle October 23, 2020 19:07
@beyackle
Copy link
Contributor

@beyackle FYI.
As you suggested, I ran the yarn l10n script and committed the resulting changes to en-US.json.
But why am I seeing more changes to the en-US file than what I updated? Please take a look.

That's the result of other earlier changes that didn't run the script. I'm okay with merging these just so the file stays up-to-date without needing another PR just to take care of those.

@zxyanliu
Copy link
Contributor Author

@beyackle FYI.
As you suggested, I ran the yarn l10n script and committed the resulting changes to en-US.json.
But why am I seeing more changes to the en-US file than what I updated? Please take a look.

That's the result of other earlier changes that didn't run the script. I'm okay with merging these just so the file stays up-to-date without needing another PR just to take care of those.

Thank you! That makes sense to me.

@beyackle beyackle merged commit e828b62 into main Oct 23, 2020
@beyackle beyackle deleted the zxyanliu/errorMessage/20201022 branch October 23, 2020 19:35
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* Update constants.ts

* run scripts and bring changes to the en-us file.

Co-authored-by: Ben Yackley <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggested refinement of the validation error messages

4 participants