Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

feat: Updated js runtime to use the latest SDK #4494

Merged
cwhitten merged 35 commits into from
Dec 1, 2020
Merged

feat: Updated js runtime to use the latest SDK #4494

cwhitten merged 35 commits into from
Dec 1, 2020

Conversation

@chon219
Copy link
Member

@chon219 chon219 commented Oct 23, 2020 •
edited
Loading

Description

Close #3893

Updated js runtime to use the latest version of SDK to adopt the latest changes.
Added schemas folder to js runtime.
Updated eject function to copy schemas folder to project folder in js runtime.
Added sample of custom action to js runtime.

Task Item

Screenshots

@chon219
Copy link
Member Author

chon219 commented Oct 23, 2020

We can change the version of sdk to 4.11 once 4.11 released. For now, I have to use next version.

@coveralls
Copy link

coveralls commented Oct 23, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.008%) to 55.377% when pulling f00a423 on zim/update-js-runtime into 20e1d91 on main.

luhan2017
luhan2017 reviewed Oct 26, 2020
View reviewed changes
luhan2017
luhan2017 reviewed Oct 29, 2020
View reviewed changes
@lgtm-com
Copy link

lgtm-com bot commented Oct 29, 2020

This pull request fixes 1 alert when merging 3f1cede into 1227d93 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@luhan2017
Copy link
Contributor

luhan2017 commented Oct 30, 2020

@chon219 could you please check the test cases failure especially for the BotProject-nodejs.

@chon219
Copy link
Member Author

chon219 commented Oct 30, 2020

@chon219 Zichuan Ma FTE could you please check the test cases failure especially for the BotProject-nodejs.

OK, I'll try to fix that.

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 1 alert when merging 8c52fe0 into 0729434 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Oct 30, 2020

This pull request fixes 1 alert when merging 4e95867 into 72e5700 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

luhan2017
luhan2017 reviewed Nov 3, 2020
View reviewed changes
@lgtm-com
Copy link

lgtm-com bot commented Nov 3, 2020

This pull request fixes 1 alert when merging af295a1 into 77ad8e1 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@luhan2017
Copy link
Contributor

luhan2017 commented Nov 4, 2020

@chon219 , schemas are already in JS RC3, let's take that package and support JS custom action in this PR.

@lgtm-com
Copy link

lgtm-com bot commented Nov 5, 2020

This pull request fixes 1 alert when merging 0cc31fe into d5b2950 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Nov 5, 2020

This pull request fixes 1 alert when merging a85257f into b762301 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@luhan2017
Copy link
Contributor

luhan2017 commented Nov 12, 2020

--imports="../dialogs/imported" what does this mean? I tried that and didn't see any folder created.

@a-b-r-o-w-n a-b-r-o-w-n added the 1.3 1.3 Release label Nov 13, 2020
@cwhitten
Copy link
Member

cwhitten commented Nov 17, 2020

ping @chon219

@chon219
Copy link
Member Author

chon219 commented Nov 26, 2020

--imports="../dialogs/imported" what does this mean? I tried that and didn't see any folder created.

Imported assets from referenced packages (exported folder) would be copied into dialogs/imported to be consumed by composer, which might be empty if there is no imported assets.

@chon219
Copy link
Member Author

chon219 commented Nov 26, 2020

@benbrown All comments resolved, is it okay to merge this change?

@cwhitten cwhitten merged commit bc7caa2 into main Dec 1, 2020
@cwhitten cwhitten deleted the zim/update-js-runtime branch December 1, 2020 01:34
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@chon219 @luhan2017 @cwhitten
feat: Updated js runtime to use the latest SDK (microsoft#4494)
0c6dbd6 
* updated js runtime to match the latest sdk

* updated composerbot of js runtime

* updated sdk to 4.11.0-rc1

* fixed test failure for js runtime

* updated sdk to 4.11 rc3

* added schemas in node runtime

* copy schemas folder while ejecting

* added sample for custom action

* inline comments and converters

* updated update-schema script

* more inline comments

* updated js runtime to 4.11.0

Co-authored-by: Lu Han <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@benbrown benbrown Awaiting requested review from benbrown

2 more reviewers

@cwhitten cwhitten cwhitten approved these changes

@luhan2017 luhan2017 luhan2017 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

1.3 1.3 Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add doc and sample for JS runtime custom actions

7 participants

@chon219 @coveralls @luhan2017 @cwhitten @benbrown @a-b-r-o-w-n