This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
fix: Check the name without a number at the beginning when creating a new dialog #4493
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a8ffe35
fix: Check the dialog name without a number at the beginning when cre…
lei9444 7544bb9
Merge branch 'main' into dialogname
boydc2014 5b5fbf3
add validate to the shared
lei9444 b8308e6
Merge branch 'dialogname' of https://github.com/lei9444/BotFramework-…
lei9444 02e08fc
fix unit test
lei9444 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| import { dialogNameRegex } from '../src/constants'; | ||
|
|
||
| describe('check dialog name', () => { | ||
| it('don not support special characters', () => { | ||
| expect(dialogNameRegex.test('*a')).toBeFalsy(); | ||
| expect(dialogNameRegex.test('c*a')).toBeFalsy(); | ||
| expect(dialogNameRegex.test('c a')).toBeFalsy(); | ||
| }); | ||
|
|
||
| it('don not support number at the beginning.', () => { | ||
| expect(dialogNameRegex.test('1a')).toBeFalsy(); | ||
| expect(dialogNameRegex.test('a1')).toBeTruthy(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.