This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: correctly read project paths on Windows #4483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyackle
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
beyackle
changed the title
beyackle
changed the title
srinaath
reviewed
Oct 22, 2020
| }; | ||
|
|
||
| const renderDialogHeader = (skillId: string, dialog: DialogInfo) => { | ||
| const warningContent = notificationMap[currentProjectId][dialog.id] |
Contributor
There was a problem hiding this comment.
is it better to put both error and warning content inside if(notificationMap[currentProjectId][dialog.id]) instead of typescript ?
Contributor
Author
There was a problem hiding this comment.
I think it's about equivalent. I've gotten used to using ?. for cases like this.
srinaath
approved these changes
Oct 22, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Update en-US.json * add serverside path check for Windows and some null checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Loading multi-skill bots was broken on Windows due to strange behavior in Node's own
path.resolvefunction, where it returns paths like/C:/Users. The leading slash breaks the server's ability to load files, so now we detect it. This also adds some null-checking for safety to the ProjectTree so you can load in a multi-bot project even on Windows and see it displayed (although the links won't work yet; that PR is still in progress).Task Item
#minor
Screenshots