Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@srinaath
Copy link
Contributor

Description

This PR removes workspace reference in Bot Project file. This file would always be nested directly inside the Root Bot. All skills added would be referred using a relative path from the root bot. A typo was made with the version of BotProject file. Changing it to 0.2.0 and will be upgraded to 1.0.0 at the end of R11.

Fixes #4162

Srinaath Ravichandran and others added 21 commits July 29, 2020 15:05
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
…oser into srravich/bot-projects-schema

Signed-off-by: Srinaath Ravichandran <[email protected]>

# Conflicts:
#	Composer/.gitignore
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
@srinaath srinaath changed the title Bot Project Schema Update feat: Bot Project Schema Update Oct 20, 2020
@coveralls
Copy link

coveralls commented Oct 20, 2020

Coverage Status

Coverage decreased (-0.02%) to 55.354% when pulling 29a7fd2 on srravich/bot-projects-schema into 6421cdb on main.

// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import path from 'path';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You sure you can use this module on the browser?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. @hatpick and me had an offline conversation about this.

#4437 This would be the ticket that should do a cleanup of the path module throughout our codebase in non node context

@srinaath srinaath requested a review from tdurnford October 20, 2020 18:59
@cwhitten cwhitten merged commit 617e350 into main Oct 21, 2020
@cwhitten cwhitten deleted the srravich/bot-projects-schema branch October 21, 2020 01:41
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* Added schema for bot project support

Signed-off-by: Srinaath Ravichandran <[email protected]>

* Add 1.0 botproject schema

Signed-off-by: Srinaath Ravichandran <[email protected]>

* Fix typo

Signed-off-by: Srinaath Ravichandran <[email protected]>

* Updated gitignore

Signed-off-by: Srinaath Ravichandran <[email protected]>

* Typo fixed

Signed-off-by: Srinaath Ravichandran <[email protected]>

* Following sdk.schema approach to specificy object type using ref

Signed-off-by: Srinaath Ravichandran <[email protected]>

* Fix schema

Signed-off-by: Srinaath Ravichandran <[email protected]>

* Removed workspace references.

Signed-off-by: Srinaath Ravichandran <[email protected]>

* Relative path support

Signed-off-by: Srinaath Ravichandran <[email protected]>

* Update operations on Bot project file

Signed-off-by: Srinaath Ravichandran <[email protected]>

* Updated tests for removing workspace reference

Signed-off-by: Srinaath Ravichandran <[email protected]>

* Removed manifest update operation

Signed-off-by: Srinaath Ravichandran <[email protected]>

* Cleared logs

Signed-off-by: Srinaath Ravichandran <[email protected]>

Co-authored-by: Srinaath Ravichandran <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BotProject file (.botProj) Operations

5 participants