This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
feat: Bot Project Schema Update #4431
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinaath Ravichandran <[email protected]>
…oser into srravich/bot-projects-schema
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
…oser into srravich/bot-projects-schema Signed-off-by: Srinaath Ravichandran <[email protected]> # Conflicts: # Composer/.gitignore
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
…oser into srravich/bot-projects-schema
…rosoft/BotFramework-Composer into srravich/bot-projects-schema
Signed-off-by: Srinaath Ravichandran <[email protected]>
…oser into srravich/bot-projects-schema
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
…oser into srravich/bot-projects-schema
Signed-off-by: Srinaath Ravichandran <[email protected]>
hatpick
reviewed
Oct 20, 2020
| // Copyright (c) Microsoft Corporation. | ||
| // Licensed under the MIT License. | ||
|
|
||
| import path from 'path'; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You sure you can use this module on the browser?
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cwhitten
approved these changes
Oct 21, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Added schema for bot project support Signed-off-by: Srinaath Ravichandran <[email protected]> * Add 1.0 botproject schema Signed-off-by: Srinaath Ravichandran <[email protected]> * Fix typo Signed-off-by: Srinaath Ravichandran <[email protected]> * Updated gitignore Signed-off-by: Srinaath Ravichandran <[email protected]> * Typo fixed Signed-off-by: Srinaath Ravichandran <[email protected]> * Following sdk.schema approach to specificy object type using ref Signed-off-by: Srinaath Ravichandran <[email protected]> * Fix schema Signed-off-by: Srinaath Ravichandran <[email protected]> * Removed workspace references. Signed-off-by: Srinaath Ravichandran <[email protected]> * Relative path support Signed-off-by: Srinaath Ravichandran <[email protected]> * Update operations on Bot project file Signed-off-by: Srinaath Ravichandran <[email protected]> * Updated tests for removing workspace reference Signed-off-by: Srinaath Ravichandran <[email protected]> * Removed manifest update operation Signed-off-by: Srinaath Ravichandran <[email protected]> * Cleared logs Signed-off-by: Srinaath Ravichandran <[email protected]> Co-authored-by: Srinaath Ravichandran <[email protected]> Co-authored-by: Chris Whitten <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes workspace reference in Bot Project file. This file would always be nested directly inside the Root Bot. All skills added would be referred using a relative path from the root bot. A typo was made with the version of BotProject file. Changing it to 0.2.0 and will be upgraded to 1.0.0 at the end of R11.
Fixes #4162