Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

fix: Making sure placeholder works for ArrayFields #4412

Merged
cwhitten merged 3 commits into from
Oct 19, 2020
Merged

fix: Making sure placeholder works for ArrayFields #4412

cwhitten merged 3 commits into from
Oct 19, 2020

Conversation

@LouisEugeneMSFT
Copy link
Contributor

@LouisEugeneMSFT LouisEugeneMSFT commented Oct 16, 2020

Description

This PR addresses placeholders for ArrayFields (see screenshot).

  • TextField in ArrayField needs to leverage placeholder from its props
  • That same placeholder needs to be overwritten by the examples in the ArrayFieldItem children, thus resetting the placeholder (undefined) at this level so that getUiPlaceholder can resolver to the examples later on.

Task Item

fixes #3908

Screenshots

image

@coveralls
Copy link

coveralls commented Oct 16, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 55.694% when pulling bf6f47c on leugene/issue3908 into 9406fb4 on main.

@LouisEugeneMSFT LouisEugeneMSFT changed the title Making sure placeholder works for ArrayFields fix: Making sure placeholder works for ArrayFields Oct 19, 2020
@cwhitten cwhitten merged commit 55fea4c into main Oct 19, 2020
@cwhitten cwhitten deleted the leugene/issue3908 branch October 19, 2020 21:28
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@LouisEugeneMSFT @cwhitten
Making sure placeholder works for ArrayFields (microsoft#4412)
4cd0bc4 
Co-authored-by: Chris Whitten <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

1 more reviewer

@cwhitten cwhitten cwhitten approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Validation rule field should include a placeholder tip

4 participants

@LouisEugeneMSFT @coveralls @cwhitten