This repository was archived by the owner on Jul 9, 2025. It is now read-only.
chore: move plugins folder outside of Composer #4399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
requested review from
GeoffCoxMSFT,
benbrown,
beyackle,
boydc2014,
carlosscastro,
cwhitten,
hatpick,
luhan2017,
srinaath and
tonyanziano
as code owners
Contributor
Author
|
Can someone on windows test this with a clean checkout? |
Contributor
|
This scares me! There is a big PR involving the azurePublish plugin. Any chance we can let that land before we move all the files around? |
Contributor
Author
|
@benbrown git should be able to handle the conflict since no source code was changed. |
Contributor
Author
|
@benbrown if you tell me the branch you are working on I can do a merge locally to see. |
Contributor
|
|
tonyanziano
reviewed
Oct 16, 2020
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
Some minor comments. I'll defer to how the merging of the azure publish branch goes
tonyanziano
reviewed
Oct 16, 2020
Contributor
Author
|
That branch isn't set to merge until later next week. So we'll merge this when ready and I will manage the conflicts. |
tonyanziano
previously approved these changes
Oct 16, 2020
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
Looks good once merge conflicts are fixed
This was referenced Oct 19, 2020
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* move plugins out of composer directory * add compileExtensions script * update references to old plugins directory * add types dependency back * revert typo * ensure that composer libs are built before extensions * force install when extension needs to compile * use git to determine last modified date * update lockfiles * fix ts error * always yarn install and warn if no build script
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also renames it to extensions.
This will help avoid yarn workspace issues with transient dependencies. Extensions should be considered external/isolated modules.
Task Item
#minor