This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Updates regular expressions formatting and naming convention #4398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevkan
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath,
tonyanziano and
yeze322
as code owners
Contributor
|
@a-b-r-o-w-n |
a-b-r-o-w-n
approved these changes
Oct 16, 2020
Member
|
thank you @stevkan ! |
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The naming convention between the different recognizer types is inconsistent when the user clicks on the associated dropdown. These changes are implemented to bring consistency across the various JSON, .spec.ts, and .dialog files.
Task Item
Replaces #4297
Closes #4060
Screenshots
e2e test: