This repository was archived by the owner on Jul 9, 2025. It is now read-only.
chore: enable easier electron builds by hosting some packages #4383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
requested review from
GeoffCoxMSFT,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath,
tonyanziano and
yeze322
as code owners
a-b-r-o-w-n
commented
Oct 15, 2020
| data?: any; | ||
| } | ||
| const VisualDesigner: React.FC<VisualDesignerProps> = ({ onFocus, onBlur, schema }): JSX.Element => { | ||
| const VisualDesigner: React.FC<VisualDesignerProps> = ({ onFocus, onBlur, schema, data: inputData }): JSX.Element => { |
Contributor
Author
There was a problem hiding this comment.
@yeze322 can you look at this in particular? I removed data from the shell, requiring the editor contexts to decide how to get their own data. Eventually, the useShell hook will be agnostic to where it is getting invoked, but I will follow up this PR with that work.
tonyanziano
suggested changes
Oct 15, 2020
tonyanziano
approved these changes
Oct 15, 2020
yeze322
reviewed
Nov 5, 2020
| // we need to reset the local value | ||
| useEffect(() => { | ||
| const pattern = getRegexIntentPattern(currentDialog, intentName); | ||
| const pattern = getRegexIntentPattern(formData, intentName); |
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…oft#4383) * decompose shell and api into smaller types * nest plugin pages under bot scope * simplify webpack config * make extension client external * add mechanism to sync client shell to iframe plugin host * only fetch extensions when app mounts * add plugin pages selector * output source maps with extension bundles * rename file * clean up manifest after loading extensions * add project api hook * update sample plugin to use project api * disable sample-ui-plugin * do not sync store to window * prepare test-utils and types for publishing * update package references to published pacakges * add types package * remove shared dependency from extension-client * remove data from shell * more types updates * add useFormHook to expose current form data * re-order useEffects * add missing import * move types to dependencies * fix type errors * add missing dependency * fix tests * remove old comments * update lockfile * use stub currentDialog when none found * fix build:dev * fix merge conflict * add @botframework-composer/types to client
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@botframework-composernpm scope for some shared packages that can be installed inside of plugins. This reduces the yarn workspace magic and fixes electron builds due to missing dependencies.@bfc/shareddependency from@bfc/extension-clientto ease installation outside of the workspace and in preparation for publishing.Task Item
#minor