Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

feat: Update LG library #4368

Merged
cwhitten merged 16 commits into from
Oct 20, 2020
Merged

feat: Update LG library #4368

cwhitten merged 16 commits into from
Oct 20, 2020

Conversation

@Danieladu
Copy link
Contributor

@Danieladu Danieladu commented Oct 14, 2020 •
edited
Loading

Description

C# Code js Code
PR link PR link 
(sourceId: string, resourceId: string) -> { content: string; id: string }

to

(lgResource:LGResource) => LGResource

Task Item

closes #3982

@coveralls
Copy link

coveralls commented Oct 19, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 55.652% when pulling 8ef6095 on hond/lg into c98037f on main.

@Danieladu Danieladu marked this pull request as ready for review October 19, 2020 03:21
@Danieladu Danieladu marked this pull request as draft October 19, 2020 03:22
@Danieladu Danieladu marked this pull request as ready for review October 19, 2020 03:43
@boydc2014
Copy link
Contributor

boydc2014 commented Oct 19, 2020

@zhixzhan can you help review this one?

@zhixzhan
Copy link
Contributor

zhixzhan commented Oct 19, 2020

@zhixzhan can you help review this one?

Sure, I will

zhixzhan
zhixzhan reviewed Oct 19, 2020
View reviewed changes
@zhixzhan
Copy link
Contributor

zhixzhan commented Oct 19, 2020

I have tested few LG scenarios inline/allupview/listview/diagnostics, and run in emulator, it E2E works.

boydc2014
boydc2014 previously approved these changes Oct 19, 2020
View reviewed changes
@boydc2014 boydc2014 added the Approved to merge approved, waiting to be merged label Oct 19, 2020
@cwhitten cwhitten merged commit 7701b01 into main Oct 20, 2020
@cwhitten cwhitten deleted the hond/lg branch October 20, 2020 00:24
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
Merged
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
@Danieladu @zhixzhan
@boydc2014 @cwhitten
feat: Update LG library (microsoft#4368)
b5296be 
* init

* update LG library

* migrate LgFile to LGResource

* fix issue

* update package entry

* app lint:fix command

* remove untracked files

* update yarn.lock

* fix comments

* revert schema file

Co-authored-by: zhixzhan <[email protected]>
Co-authored-by: Dong Lei <[email protected]>
Co-authored-by: Chris Whitten <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@a-b-r-o-w-n a-b-r-o-w-n Awaiting requested review from a-b-r-o-w-n

@beyackle beyackle Awaiting requested review from beyackle

@GeoffCoxMSFT GeoffCoxMSFT Awaiting requested review from GeoffCoxMSFT

@hatpick hatpick Awaiting requested review from hatpick

@srinaath srinaath Awaiting requested review from srinaath

@tonyanziano tonyanziano Awaiting requested review from tonyanziano

@yeze322 yeze322 Awaiting requested review from yeze322

3 more reviewers

@zhixzhan zhixzhan zhixzhan left review comments

@cwhitten cwhitten cwhitten approved these changes

@boydc2014 boydc2014 boydc2014 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved to merge approved, waiting to be merged Team: Authoring Team: Platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LG namespace option should not be required

6 participants

@Danieladu @coveralls @boydc2014 @zhixzhan @cwhitten