This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Guard selectors against partially loaded project #4367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinaath Ravichandran <[email protected]>
srinaath
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick and
tonyanziano
as code owners
Signed-off-by: Srinaath Ravichandran <[email protected]>
Contributor
Author
|
@hatpick Since im not able to recreate this error on my machine. Can u give a functional test of this branch? |
srinaath
changed the title
Contributor
I can confirm that it works on my machine. I tried it bunch of times. |
srinaath
changed the title
Signed-off-by: Srinaath Ravichandran <[email protected]>
beyackle
approved these changes
Oct 14, 2020
Contributor
beyackle
left a comment
beyackle
left a comment
There was a problem hiding this comment.
LGTM (and thanks for the example of how to write a test that involves Recoil state)
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Guard selectors against partially loaded project Signed-off-by: Srinaath Ravichandran <[email protected]> * Group the dependancies Signed-off-by: Srinaath Ravichandran <[email protected]> * Fix unit test Signed-off-by: Srinaath Ravichandran <[email protected]> Co-authored-by: Srinaath Ravichandran <[email protected]> Co-authored-by: Ben Yackley <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4366