This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: Taking control of recognizer dialog generation and crosstrain config #4351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r authored bot CI/CD friendly
lei9444
changed the title
lei9444
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
yeze322
reviewed
Oct 14, 2020
yeze322
reviewed
Oct 14, 2020
Member
|
@lei9444 in an attempt to resolve conflicts, lint is failing with: Error: [typecheck:server] src/models/bot/tests/botProject.test.ts(296,52): error TS2345: Argument of type '{ luisConfig: { authoringEndpoint: string; authoringKey: string; authoringRegion: string; defaultLanguage: string; endpoint: string; endpointKey: string; environment: string; name: string; }; ... 4 more ...; recognizerTypes: RecognizerTypes; }' is not assignable to parameter of type 'IBuildConfig'. |
Contributor
Author
|
The azurePublish plugin has the build logic. I will remove the build from the plugin and guarantee the bot project is built before publishing(decouple the luisQna build and azure publish). |
cwhitten
approved these changes
Oct 16, 2020
3 tasks
Merged
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…onfig (microsoft#4351) * feat: Taking control of recognizer dialog generation and make composer authored bot CI/CD friendly * update the kind string * add some comments * add unit tests * fix unit test * fix build file config * update the package * update the cross train config file name * fix test * update the update function * use cli replace the sampler * update the bot test * fix test Co-authored-by: Chris Whitten <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#4259
Task Item
closes #4259
closes #3811
closes #3370
closes #4205
Screenshots