This repository was archived by the owner on Jul 9, 2025. It is now read-only.
refactor: add @bfc/types package #4336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
requested review from
GeoffCoxMSFT,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath,
tonyanziano and
yeze322
as code owners
tonyanziano
suggested changes
Oct 7, 2020
Contributor
tonyanziano
left a comment
tonyanziano
left a comment
There was a problem hiding this comment.
Minor comments. Other than that, great job, I think this is much cleaner
Composer/packages/client/src/pages/plugin/pluginPageContainer.tsx
Outdated
Show resolved
Hide resolved
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* refactor plugin host webpack config * add bundleId to publish type config * add types package * update yarn build:dev and add @bfc/tools to deps * build client before server * update imports to use @bfc/types * fix getBundleForView test * update remaining extension type references * fix additionalProperties typing * add @bfc/ui-shared where missing * fix extensions controller test * do not extract comments when bundling react * apply pr feedback * update more imports from shared to types * convert interfaces to types
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracts shared types from
@bfc/sharedand@bfc/extension*into a single package that only exports types and interfaces. This package will eventually be published to npm and consumed by the extension packages.The public interface of
@bfc/shareddoes not change, as it re-exports the types.Task Item
closes #4274