This repository was archived by the owner on Jul 9, 2025. It is now read-only.
Fix authentication configuration #4314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bot wasn't starting complaning that the service Microsoft.Bot.Connector.Authentication.AuthenticationConfiguration wasn't found.
It's a common exception when something is not added to the ServiceProviders, therefore, the DI engine cannot find it.
When the screen for Skills were created, a validation to check whether it is a skill or not was also added, because the AllowedCallersClaimsValidator method.
If not, the AuthenticationConfiguration wasn't added:
Later on the Startup.cs, on the GetBotAdapter method, when creating the BotFrameworkHttpAdapter, the ServiceProvider was called to get the AuthenticationConfiguration method, which did not exist, causing the exception.
Since, on the Service Locator Pattern, optional Dependencies are considered an anti-pattern, the AuthenticationConfiguration should always exists, and not be branched.
For that to work, the Singleton for AuthenticationConfiguration should be changed to:
Task Item
Closes #4313