This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Typing too fast in composer results in dropped characters #4298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
a-b-r-o-w-n,
boydc2014 and
cwhitten
as code owners
yeze322
approved these changes
Sep 30, 2020
8 tasks
boydc2014
approved these changes
Sep 30, 2020
Merged
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…soft#4298) * fix typing * add some comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The root cause is the same as #4171
The reason is
dialog data update -> setSelectedIds([]) -> onSelect -> shell state change
This looks like a anti-pattern
There is a small demo code: https://codesandbox.io/s/test-jy65g?file=/src/index.js
This is a quick fix for the input typing issue now, next step @yeze322 will refactor the ids‘ computation (selectedIds and focusedid)
Task Item
closes #4102
refs #4171
Screenshots