This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: form dialog extension #4296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hatpick
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
srinaath and
tonyanziano
as code owners
hatpick
added
the
Area: Form Dialogs
cwhitten
reviewed
Oct 1, 2020
Member
cwhitten
left a comment
cwhitten
left a comment
There was a problem hiding this comment.
submitting comments so far. this diff will take awhile to go through
GeoffCoxMSFT
reviewed
Oct 1, 2020
GeoffCoxMSFT
reviewed
Oct 1, 2020
GeoffCoxMSFT
reviewed
Oct 1, 2020
GeoffCoxMSFT
reviewed
Oct 1, 2020
GeoffCoxMSFT
reviewed
Oct 1, 2020
Composer/packages/form-dialogs/src/components/common/CommandBarUpload.tsx
Show resolved
Hide resolved
GeoffCoxMSFT
reviewed
Oct 1, 2020
Composer/packages/form-dialogs/src/components/property/PropertyTypeSelector.tsx
Show resolved
Hide resolved
GeoffCoxMSFT
reviewed
Oct 1, 2020
GeoffCoxMSFT
reviewed
Oct 1, 2020
GeoffCoxMSFT
reviewed
Oct 1, 2020
GeoffCoxMSFT
reviewed
Oct 1, 2020
Member
|
I think this PR won't affect the current UI as it isn't wired into Composer top-level, correct? When we get to the PR does does make this show up, let's be sure it is behind the feature switching mechanism. |
GeoffCoxMSFT
previously approved these changes
Oct 1, 2020
GeoffCoxMSFT
approved these changes
Oct 2, 2020
Contributor
Author
@cwhitten I'm going to merge this PR since as Geoff has said it too, it will not affect any part of the Composer. I'm open to further comments and suggestions and will PR them separately if there were any. |
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Form dialogs init * new design * UX comments * conflicts resolved * yarn * click outside to dismiss expanded * Fix yarn.lock * PR comments * fix demo Co-authored-by: Soroush <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Form dialog extension UI
This PR adds the UI for creating form dialog schema. Once the project tree is ready, form dialog will be integrated into the client web app.
Task Item
closes #4145
closes #4146
Screenshots
(demo)
