This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
fix: Disable the default timeout for requests on the LU build #4295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…step which can take > 2 minutes for large models
Contributor
|
Although this addresses #4294, we should attempt to refactor this endpoint to better fit long processes, like polling or web socket. |
Contributor
Author
|
I agree @a-b-r-o-w-n and have a proposal that I will follow up with ASAP. In short: we already implement a polling procedure for the publishing. I would like to formalize this so that publishing, provisioning, and building can take advantage of the same subsystem. |
Contributor
|
@benbrown that's good to hear. |
Member
|
Test environment is failing with: TypeError: req.setTimeout is not a function Maybe we need to shim this api in the test runner? |
Member
|
@benbrown i don't know why tests are failing but it seems specific to this change |
Contributor
Author
|
@cwhitten I think I found it. Just pushed a small change to the test. |
cwhitten
approved these changes
Nov 17, 2020
EricDahlvang
pushed a commit
that referenced
this pull request
Nov 27, 2020
* Fix #4294 - Disable the default timeout for requests on the LU build step which can take > 2 minutes for large models * update mocked request object to contain settimeout Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
benbrown
added a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
…oft#4295) * Fix microsoft#4294 - Disable the default timeout for requests on the LU build step which can take > 2 minutes for large models * update mocked request object to contain settimeout Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
benbrown
added a commit
that referenced
this pull request
Jun 11, 2021
* Fix #4294 - Disable the default timeout for requests on the LU build step which can take > 2 minutes for large models * update mocked request object to contain settimeout Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…oft#4295) * Fix microsoft#4294 - Disable the default timeout for requests on the LU build step which can take > 2 minutes for large models * update mocked request object to contain settimeout Co-authored-by: Chris Whitten <christopher.whitten@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the timeout behavior on the /build endpoint, which can result in a network error when publishing a large language model. By default, Node's HTTP server class is set to timeout after 2 minutes.
https://nodejs.org/dist/latest-v6.x/docs/api/http.html#http_server_settimeout_msecs_callback
Task Item
fixes #4294